Repository navigation
test: run test modules headless unless they need a workbench - #1622
Draft
joaodinissf wants to merge 1 commit into
Draft
joaodinissf wants to merge 1 commit into
joaodinissf wants to merge 1 commit into
Conversation
joaodinissf
force-pushed
the
headless-harness-step-2
branch
from
November 15, 2026 19:07
b66ed24 to
402b761
Compare
Test modules use Tycho's default headless harness. A module that needs a workbench opts in by setting tycho.surefire.useUIHarness=true, and fails loudly otherwise, so a new module does not start a workbench by accident. Seven modules need one and opt in: check.core.test, check.ui.test, test.ui.test, checkcfg.core.test, check.test.runtime.tests, sample.helloworld.ui.test and xtext.ui.test. Only these take the Surefire reactor lock (test.reactorConcurrencyLevel=1), since a workbench could take focus from a SWTBot test in another one. The other seven have no workbench and run in parallel under -T. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joaodinissf
force-pushed
the
headless-harness-step-2
branch
from
November 16, 2026 08:25
402b761 to
a28f0a9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test modules now run under Tycho's default headless harness, so a module only starts a workbench if it asks for one. Based on #1599, which should merge first.
tycho.surefire.useUIHarness=trueandtest.reactorConcurrencyLevel=1, so they take turns under-T:check.core.test,check.ui.test,test.ui.test,checkcfg.core.test,check.test.runtime.tests,sample.helloworld.ui.test,xtext.ui.test.test,typesystem.test,xtext.export.test,check.runtime.core.test,xtext.test,xtext.generator.test,xtext.format.test.PlatformUI.getWorkbench()throws, and the Check injector can't be created without anIWorkbench.AGENTS.mdexplains how to opt in.Performance
Local builds on macOS with Temurin 21. The
masterand #1599 figures come from earlier runs on older bases, and other work was running on the machine, so small differences are noise.master-T 3C-T 3Cmaster. That comes from one runtime per module in test: run each test bundle in its own runtime with JUnit discovery #1599; this PR recovers part of it.Validation
./mvnw -U -T 3C clean verify checkstyle:check pmd:pmd pmd:cpd pmd:check pmd:cpd-check spotbugs:check -f ddk-parent/pom.xml --batch-mode --fail-at-endpasses.Known limits
checkcfg.core.testhit aConcurrentModificationExceptionin validation once when tried headless. It's unexplained, and it hasn't recurred with that module on the UI harness.🤖 Generated with Claude Code